Remove some Prophecy usage #6416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces the number of warnings using PHPUnit 9.
franmomu
commented
Sep 25, 2020
| @@ -2959,10 +2973,24 @@ public function testCanonicalizedLocaleForMoment(?string $expected, string $orig | |||
|
|
|||
| public function testIsGrantedAffirmative(): void | |||
| { | |||
| $this->securityChecker | |||
There was a problem hiding this comment.
This has been moved where it is actually used and I changed a little because before:
$this->securityChecker->isGranted(['foo', 'bar'], null)->willReturn(false);
$this->securityChecker->isGranted(Argument::type('string'), null)->willReturn(true);The first line was wrong because the implementation calls isGranted always with just one $role.
What about rising our requirements to 7.3? Since 7.2 is in security fix state. I think it's ok to do that. |
Anyway, we were considering trying to stop using it. |
Merged
|
Done in #6421 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since sonata-project/dev-kit#1014, test on PHP 8 fail because a lot of warnings are thrown in PHPUnit 9, most of them coming because of the use of Prophecy.
Ref: sonata-project/dev-kit#624
From 693 warnings to 156.
We cannot require
phpspec/prophecy-phpunitbecause it requires PHP 7.3.